RE: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

From: êìí/ìììêì/SW Platform(ì)AOTí(hugh.kang@lge.com)
Date: Sun Sep 18 2016 - 20:13:02 EST


You're welcome. Will be merged this patch?
Thank you

Hugh Kang

No One ever is defeated until defeat has been accepted as a reality.
êìí (Hugh Kang) Chief Engineer
SW Platform(ì) Advanced OS Technology TEAM (AOT)
Mobile: +82-10-5513-7957

-----Original Message-----
From: Javi Merino [mailto:javi.merino@xxxxxxx]
Sent: Thursday, September 08, 2016 5:26 PM
To: Inhyuk Kang
Cc: Viresh Kumar; amit.kachhap@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; Eduardo Valentin; Rui Zhang
Subject: Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote:
> The last_load is updated not cpufreq_get_actual_power() function call
> but cpufreq_get_requested_power() function call.

Yep, my bad. Thanks for fixing it!

> Signed-off-by: Inhyuk Kang <hugh.kang@xxxxxxx>

Acked-by: Javi Merino <javi.merino@xxxxxxx>

> diff --git a/drivers/thermal/cpu_cooling.c
> b/drivers/thermal/cpu_cooling.c index a32b417..9ce0e9e 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -74,7 +74,7 @@ struct power_table {
> * cpufreq frequencies.
> * @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
> * @node: list_head to link all cpufreq_cooling_device together.
> - * @last_load: load measured by the latest call to
> cpufreq_get_actual_power()
> + * @last_load: load measured by the latest call to
> + cpufreq_get_requested_power()
> * @time_in_idle: previous reading of the absolute time that this cpu was idle
> * @time_in_idle_timestamp: wall time of the last invocation of
> * get_cpu_idle_time_us()
> --
> 1.9.1
>