Re: [PATCH v2] clk: probe common clock drivers earlier

From: Stephen Boyd
Date: Fri Sep 16 2016 - 19:12:58 EST


On 09/16, Masahiro Yamada wrote:
> Hi Stephen, Greg,
>
>
> 2016-05-20 23:49 GMT+09:00 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
> > Several SoCs implement platform drivers for clocks rather than
> > CLK_OF_DECLARE(). Clocks should come earlier because they are
> > prerequisites for many of other drivers. It will help to mitigate
> > EPROBE_DEFER issues.
> >
> > Also, drop the comment since it does not look valuable.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > ---
> >
> > Changes in v2:
> > - Move clk/ above dma/ since DMA drivers generally enable clk
> >
> > drivers/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/Makefile b/drivers/Makefile
> > index 8f5d076..ff39051 100644
> > --- a/drivers/Makefile
> > +++ b/drivers/Makefile
> > @@ -29,6 +29,8 @@ obj-$(CONFIG_SFI) += sfi/
> > # was used and do nothing if so
> > obj-$(CONFIG_PNP) += pnp/
> > obj-y += amba/
> > +
> > +obj-y += clk/
> > # Many drivers will want to use DMA so this has to be made available
> > # really early.
> > obj-$(CONFIG_DMADEVICES) += dma/
> > @@ -141,8 +143,6 @@ obj-$(CONFIG_VHOST_RING) += vhost/
> > obj-$(CONFIG_VLYNQ) += vlynq/
> > obj-$(CONFIG_STAGING) += staging/
> > obj-y += platform/
> > -#common clk code
> > -obj-y += clk/
> >
> > obj-$(CONFIG_MAILBOX) += mailbox/
> > obj-$(CONFIG_HWSPINLOCK) += hwspinlock/
>
>
> What do you think of this patch?
>

I assumed Greg would pick it up given that Mike already acked it.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project