Re: [PATCH] mm/shmem.c: constify anon_ops

From: Hugh Dickins
Date: Fri Sep 16 2016 - 15:06:41 EST


On Thu, 15 Sep 2016, Rasmus Villemoes wrote:

> Every other dentry_operations instance is const, and this one might as
> well be.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

Indeed, thanks,

Acked-by: Hugh Dickins <hughd@xxxxxxxxxx>

> ---
> mm/shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index fd8b2b5741b1..693ffdc5899a 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -4077,7 +4077,7 @@ EXPORT_SYMBOL_GPL(shmem_truncate_range);
>
> /* common code */
>
> -static struct dentry_operations anon_ops = {
> +static const struct dentry_operations anon_ops = {
> .d_dname = simple_dname
> };
>
> --
> 2.1.4