Re: [PATCH v1 3/3] ARM: dts: imx6qdl-apalis: Use enable-gpios property for backlight

From: Marcel Ziswiler
Date: Fri Sep 16 2016 - 13:12:46 EST


On Wed, 2016-09-14 at 12:05 +0530, Sanchayan Maity wrote:
> Use enable-gpios property of PWM backlight driver for backlight
> control. While at it also fix the use of brightness levels required
> by EDT displays which require inverted PWM's.

That part I am missing below. Did you forget to include it?

> Signed-off-by: Sanchayan Maity <maitysanchayan@xxxxxxxxx>
> ---
> Âarch/arm/boot/dts/imx6qdl-apalis.dtsi | 9 +++++++++
> Â1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> index 8c67dd8..9100bde 100644
> --- a/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-apalis.dtsi
> @@ -49,7 +49,10 @@
> Â
> Â backlight: backlight {
> Â compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> Â pwms = <&pwm4 0 5000000>;
> + enable-gpios = <&gpio3 13 GPIO_ACTIVE_HIGH>;
> Â status = "disabled";
> Â };
> Â
> @@ -614,6 +617,12 @@
> Â >;
> Â };
> Â
> + pinctrl_gpio_bl_on: gpioblon {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_DA13__GPIO3_IO13 0x1b0b0
> + >;
> + };
> +
> Â pinctrl_gpio_keys: gpio1io04grp {
> Â fsl,pins = <
> Â /* Power button */