Re: [PATCH v10 3/3] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

[Thierry Reding]

On Fri, Aug 26, 2016 at 08:07:07AM +0530, Vinay Simha BN wrote:
> Add support for the JDI LT070ME05000 WUXGA DSI panel used in
> Nexus 7 2013 devices.
> 
> Programming sequence for the panel is was originally found in the
> android-msm-flo-3.4-lollipop-release branch from:
>     https://android.googlesource.com/kernel/msm.git
> 
> And video mode setting is from dsi-panel-jdi-dualmipi1-video.dtsi
> file in:
>     git://codeaurora.org/kernel/msm-3.10.git  LNX.LA.3.6_rb1.27
> 
> Cc: Archit Taneja <archit.taneja@xxxxxxxxx>
> Cc: Rob Clark <robdclark@xxxxxxxxx>
> Cc: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> Cc: John Stultz <john.stultz@xxxxxxxxxx>
> Cc: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Signed-off-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx>
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> Signed-off-by: Vinay Simha BN <simhavcs@xxxxxxxxx>
> Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
> Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> 
> ---
> v1:
>  * sumit ported to drm/panel framework, john cherry-picked to mainline,
>    folded down other fixes from Vinay and Archit, vinay removed interface
>    setting cmd mode, video mode panel selected
> 
> v2:
>  * incorporated code reviews from theiry, archit
>    code style, alphabetical soring in Makefile, Kconfig, regulator_bulk,
>    arrays of u8, generic helper function, documentation bindings,
> 
> v3:
>  * dcs backlight support added
>  * tested this panel driver in nexus7 2013 device
> 
> v4:
>  * backlight interface added in the panel driver
>  * incorporated width_mm and height_mm suggested by rob herring
> 
> v5:
>  * theirry review comments incorporated
>    panel model naming consistent, alphabetical soring in Kconfig
>    Makefile, MAX_BRIGHTNESS dropped, regulator_names, parameterize
>    panel width and height, descprition for control display, cabc
>    and interface setting, temporary variable removed, consistent
>    error reporting and commit message
>  * removed tear on/off, scanline, since these are required only
>    for command mode panels
> 
> v6:
>  * emil review comments incorporated
>    PANEL_NUM_REGULATORS dropped, return ret added at necessary
>    places, if checks dropped for backlight and gpios
> 
> v7:
>  * emil review comments incorporated
>    added ARRAY_SIZE in struct, regulator_bulk_disable in poweroff,
>    gpios checks dropped.
>    some returns cannot be dropped, since drm panel framework return
>    type required.
> 
> v8:
>  * emil review commnets incorporated for jdi_panel_unprepare,
>    dropped the returns (ref: panel-sharp-lq101r1sx01.c) and
>    for jdi_panel_prepare(panel_on) it does not return prematurely
>    and goes to poweroff if not success
>  * few dev_err's for panel_init
> 
> v9:
>  * function drm_panel_create_dsi_backlight made as static
> 
> v10:
>  * proper naming conventions and sequence wrt panel datasheet
>    (vddp-supply, iovcc-supply,
>     enable-gpios, reset-gpios, dcdc-en-gpios)
>  * GPIO_ACTIVE_LOW polarity logic for reset-gpios
> ---
>  drivers/gpu/drm/panel/Kconfig                  |  11 +
>  drivers/gpu/drm/panel/Makefile                 |   1 +
>  drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 532 +++++++++++++++++++++++++
>  3 files changed, 544 insertions(+)
>  create mode 100644 drivers/gpu/drm/panel/panel-jdi-lt070me05000.c

Applied, thanks.

Thierry

Attachment: signature.asc
Description: PGP signature