Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2

From: Linus Torvalds
Date: Wed Sep 07 2016 - 15:15:57 EST


On Wed, Sep 7, 2016 at 11:36 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> - move page-spanning check behind a CONFIG since it's triggering false positives

Hmm. I pulled this, but looking at it I realized that

+ depends on !COMPILE_TEST

doesn't make any real sense to me.

All it does is make sure that "make allmodconfig" doesn't actually
test that the PAGESPAN code compiles.

It's not like that is a big cost for allmodconfig builds, but it does
mean that it gets less coverage.

And it really makes no sense to me. We *don't* want to run with that
option enabled normally.

I think what you actually meant was something like

+ depends on EXPERT

which means that it does *not* get enabled in normal user builds.

Hmm?

Linus