Re: [PATCH] simplefb: Disable and release clocks and regulators in destroy callback

[Hans de Goede]

Hi,

On 07-09-16 13:12, Geert Uytterhoeven wrote:
> On Wed, Sep 7, 2016 at 11:09 AM, Chen-Yu Tsai <wens@xxxxxxxx> wrote:
> > simplefb gets unregister when a proper framebuffer driver comes in and
> > kicks it out. However the claimed clocks and regulators stay enabled
> > as they are only released in the platform device remove function, which
> > in theory would never get called.
> >
> > Move the clock/regulator cleanup into the framebuffer destroy callback,
> > which gets called as part of the framebuffer unregister process.
>
> Is this called before or after the new proper framebuffer driver kicks in?
> If before, it may cause glitches.

It is called by the new proper framebuffer driver's probe method,
so it can make sure that it has already claimed / enabled the
clocks/regulators before it calls remove_conlicting_framebuffers,
avoiding the glitch.

Regards,

Hans