Re: [PATCH 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

[Hans Verkuil]

On 09/07/16 08:56, Tiffany Lin wrote:
> Add V4L2_PIX_FMT_MT21C documentation
>
> Signed-off-by: Tiffany Lin <tiffany.lin@xxxxxxxxxxxx>
> ---
>  Documentation/media/uapi/v4l/pixfmt-reserved.rst |    6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst
> index 0dd2f7f..2e21fbc 100644
> --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst
> +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst
> @@ -339,7 +339,13 @@ please make a proposal on the linux-media mailing list.
>  	  array. Anything what's in between the UYVY lines is JPEG data and
>  	  should be concatenated to form the JPEG stream.
>
> +    -  .. _V4L2-PIX-FMT-MT21C:
>
> +       -  ``V4L2_PIX_FMT_MT21C``
> +
> +       -  'MT21C'
> +
> +       -  Compressed two-planar YVU420 format used by Mediatek MT8173.

This really needs to be expanded.

Ideally this should reference the precise specification of this format if
available.

It certainly should explain which HW blocks of the mediatek SoC use this
format, it should explain that is it meant as an opaque intermediate format
between those blocks.

If you have some characteristics (i.e. is it lossy or lossless 
compression, I
presume it's lossless), then that will be useful to add as well.

We like to have as much information about formats as possible.

Regards,

	Hans

>  .. tabularcolumns:: |p{6.6cm}|p{2.2cm}|p{8.7cm}|