Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

From: Stephan Mueller
Date: Tue Sep 06 2016 - 09:16:23 EST


Am Dienstag, 6. September 2016, 14:11:56 CEST schrieb David Howells:

Hi David,

> Artem Savkov <asavkov@xxxxxxxxxx> wrote:
> > > > - select CRYPTO
> > > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y)
> > >
> > > Should those be "==" not "="?
> >
> > Accodring to Documentation/kbuild/kconfig-language.txt (line 173) it is
> > "=" and I can only see "=" being used in existing Kconfigs.
>
> Okay. The other thing is that I have been given a conflicting patch (see
> below). Is your fix preferable?

The listed patch only selects the ANSI X9.31 DRNG and thus conflicts with FIPS
mode and the current default stdrng which is the DRBG.

Ciao
Stephan