Re: [RFC] zram: support page-based parallel write

From: Andreas Mohr
Date: Tue Sep 06 2016 - 04:22:34 EST


On Tue, Sep 06, 2016 at 04:24:17PM +0900, Minchan Kim wrote:
> @@ -1464,6 +1908,9 @@ static int __init zram_init(void)
> num_devices--;
> }
>
> + if (create_workers())
> + goto out_error;
> +
> return 0;
>
> out_error:
> @@ -1474,6 +1921,7 @@ static int __init zram_init(void)
> static void __exit zram_exit(void)
> {
> destroy_devices();
> + destroy_workers();
> }


Asymmetry --> "BUG".

...right?

(I have to admit that current implementation structure
is not easy to follow,
thus I'm not fully sure)


Thanks for working in this important area!

HTH,

Andreas Mohr