Re: [v2] bcma: use of_dma_configure() to set initial dma mask

From: Arend Van Spriel
Date: Mon Sep 05 2016 - 14:34:32 EST




On 5-9-2016 17:26, Arnd Bergmann wrote:
> On Saturday, September 3, 2016 2:08:19 PM CEST Kalle Valo wrote:
>> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>>> While fixing another bug, I noticed that bcma manually sets up
>>> a dma_mask pointer for its child devices. We have a generic
>>> helper for that now, which should be able to cope better with
>>> any variations that might be needed to deal with cache coherency,
>>> unusual DMA address offsets, iommus, or limited DMA masks, none
>>> of which are currently handled here.
>>>
>>> This changes the core to use the of_dma_configure(), like
>>> we do for platform devices that are probed directly from
>>> DT.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> Nobody tested this, so I'll drop the patch.
>>
>
> Should I resend it? I think it's still required.

Maybe you should request some bcma users (RafaÅ?) explicitly to test
this. I have no equipment with CONFIG_OF enabled over here.

Regards,
Arend