Re: [PATCH v5 2/4] tracing: Add cpu as a key field in histogram

From: Daniel Wagner
Date: Mon Sep 05 2016 - 01:40:39 EST


Hi Binoy

On 09/02/2016 02:37 PM, Binoy Jayan wrote:
> The field 'cpu' although part of the set of generic fields, is not made
> part of the key fields when mentioned in the trigger command. This hack
> suggested by Daniel marks it as one of the key fields and make it appear
> in the histogram output.

While you are at it, why not adding the COMM as well? I know there is
already the common_pid.execname. With only a few extra lines we get COMM
as well and it allows to write something like

hist:key=cpu,comm:sort=cpu,comm

for example.

cheers,
daniel