Re: [PATCH v2 07/15] Simplify the confusing HIWORD_UPDATE scheme.

From: Bjorn Helgaas
Date: Fri Sep 02 2016 - 18:09:55 EST


On Fri, Sep 02, 2016 at 02:38:06PM -0700, Guenter Roeck wrote:
> On Fri, Sep 02, 2016 at 10:54:53AM -0500, Bjorn Helgaas wrote:

> > +#define HIWORD_UPDATE(mask, val) ((mask << 16) | val)
> > +
> > +#define ENCODE_LANES(x) (((x >> 1) & 3) << 4)
>
> (x) ?

Done, thanks! (And for "mask" and "val")