Re: [PATCH] xen/pciback: support driver_override

From: kbuild test robot
Date: Fri Sep 02 2016 - 08:25:14 EST


Hi Juergen,

[auto build test WARNING on xen-tip/linux-next]
[also build test WARNING on v4.8-rc4 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/Juergen-Gross/xen-pciback-support-driver_override/20160902-195956
base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: x86_64-randconfig-x001-201635 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/xen/xen-pciback/pci_stub.c: In function 'pcistub_probe':
>> drivers/xen/xen-pciback/pci_stub.c:545:1: warning: label 'out' defined but not used [-Wunused-label]
out:
^~~

vim +/out +545 drivers/xen/xen-pciback/pci_stub.c

30edc14b Konrad Rzeszutek Wilk 2009-10-13 529 && dev->hdr_type != PCI_HEADER_TYPE_BRIDGE) {
30edc14b Konrad Rzeszutek Wilk 2009-10-13 530 dev_err(&dev->dev, "can't export pci devices that "
30edc14b Konrad Rzeszutek Wilk 2009-10-13 531 "don't have a normal (0) or bridge (1) "
30edc14b Konrad Rzeszutek Wilk 2009-10-13 532 "header type!\n");
30edc14b Konrad Rzeszutek Wilk 2009-10-13 533 err = -ENODEV;
30edc14b Konrad Rzeszutek Wilk 2009-10-13 534 }
30edc14b Konrad Rzeszutek Wilk 2009-10-13 535
c77427ce Juergen Gross 2016-09-02 536 } else if (!dev->driver_override ||
c77427ce Juergen Gross 2016-09-02 537 strcmp(dev->driver_override, PCISTUB_DRIVER_NAME))
30edc14b Konrad Rzeszutek Wilk 2009-10-13 538 /* Didn't find the device */
30edc14b Konrad Rzeszutek Wilk 2009-10-13 539 err = -ENODEV;
30edc14b Konrad Rzeszutek Wilk 2009-10-13 540
c77427ce Juergen Gross 2016-09-02 541 if (!err) {
c77427ce Juergen Gross 2016-09-02 542 dev_info(&dev->dev, "seizing device\n");
c77427ce Juergen Gross 2016-09-02 543 err = pcistub_seize(dev);
c77427ce Juergen Gross 2016-09-02 544 }
30edc14b Konrad Rzeszutek Wilk 2009-10-13 @545 out:
30edc14b Konrad Rzeszutek Wilk 2009-10-13 546 return err;
30edc14b Konrad Rzeszutek Wilk 2009-10-13 547 }
30edc14b Konrad Rzeszutek Wilk 2009-10-13 548
24d8bf1b Konrad Rzeszutek Wilk 2014-04-21 549 /* Called when 'unbind'. This means we must _NOT_ call pci_reset_function or
24d8bf1b Konrad Rzeszutek Wilk 2014-04-21 550 * other functions that take the sysfs lock. */
30edc14b Konrad Rzeszutek Wilk 2009-10-13 551 static void pcistub_remove(struct pci_dev *dev)
30edc14b Konrad Rzeszutek Wilk 2009-10-13 552 {
30edc14b Konrad Rzeszutek Wilk 2009-10-13 553 struct pcistub_device *psdev, *found_psdev = NULL;

:::::: The code at line 545 was first introduced by commit
:::::: 30edc14bf39afde24ef7db2de66c91805db80828 xen/pciback: xen pci backend driver.

:::::: TO: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
:::::: CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data