Re: [PATCH v2] mmc: sdhci-msm: Add pm_runtime and system PM support

From: Pramod Gurav
Date: Thu Sep 01 2016 - 10:19:58 EST


On 1 September 2016 at 19:38, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> [...]
>
>>> +
>>> +static const struct dev_pm_ops sdhci_msm_pm_ops = {
>>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume)
>
> One more thing. Why do you need the late versions of the system PM callbacks?
>
> I think it's fine to use the regular:
> SET_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume)
>
Should have waited for this review as well. :)
Anyway I forgot to add v3 tag in my new patch.
Will resend v3 with this change as well.

> [...]
>
> Kind regards
> Uffe