Re: [PATCH 3/7] serial: 8250_fintek: Set maximum FIFO of F81216H

[Ricardo Ribalda Delgado]

Hi Peter

On Thu, Sep 1, 2016 at 5:39 AM, Ji-Ze Hong (Peter Hong)
<hpeter@xxxxxxxxx> wrote:

> +static void fintek_8250_set_max_fifo(struct fintek_8250 *pdata)
> +{
> +       switch (pdata->pid) {
> +       default: /* Default 16Bytes FIFO */
> +               return;
> +
> +       case CHIP_ID_F81216H: /* 128Bytes FIFO */
> +               sio_write_mask_reg(pdata, FIFO_CTRL,
> +                                  FIFO_MODE_MASK | RXFTHR_MODE_MASK,
> +                                  FIFO_MODE_128 | RXFTHR_MODE_4X);
> +               break;
> +       }

I think it is more clear to have the default case as the ast one;
> +}
> +
>  static int find_base_port(struct fintek_8250 *pdata, u16 io_address,
>                           unsigned int irq)

I think that we should rename find_base_port to something else like
probe_setup_port(),  we are not only finding the port but also setting
it up.

>  {
> @@ -195,6 +217,7 @@ static int find_base_port(struct fintek_8250 *pdata, u16 io_address,
>                                                 irqd_is_level_type(irq_data);
>
>                                 fintek_8250_set_irq_mode(pdata, level_mode);
> +                               fintek_8250_set_max_fifo(pdata);
>                                 fintek_8250_exit_key(addr[i]);
>
>                                 return 0;
> --
> 1.9.1
>

Regrds!


-- 
Ricardo Ribalda