Re: [PATCH v2 01/10] pinctrl: dt-bindings: samsung: Add header with values used for configuration

[Bartlomiej Zolnierkiewicz]

Hi,

On Thursday, September 01, 2016 09:23:49 AM Krzysztof Kozlowski wrote:
> Hard-coded pinctrl configuration values are scattered through DTS files.
> The numbers are difficult to decode by human, especially without the
> datasheet.  Additionally the drive strength differs between Exynos SoC
> families increasing the confusion.
> 
> The header will help making this more readable and maintainable.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> ---
>  MAINTAINERS                           |  1 +
>  include/dt-bindings/pinctrl/samsung.h | 57 +++++++++++++++++++++++++++++++++++
>  2 files changed, 58 insertions(+)
>  create mode 100644 include/dt-bindings/pinctrl/samsung.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d8e81b1dde30..836bcd327ee4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9318,6 +9318,7 @@ L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
>  L:	linux-samsung-soc@xxxxxxxxxxxxxxx (moderated for non-subscribers)
>  S:	Maintained
>  F:	drivers/pinctrl/samsung/
> +F:	include/dt-bindings/pinctrl/samsung.h
>  
>  PIN CONTROLLER - SINGLE
>  M:	Tony Lindgren <tony@xxxxxxxxxxx>
> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h
> new file mode 100644
> index 000000000000..0f410ba5ec7e
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/samsung.h
> @@ -0,0 +1,57 @@
> +/*
> + * Samsung's Exynos pinctrl bindings
> + *
> + * Copyright (c) 2016 Samsung Electronics Co., Ltd.
> + *		http://www.samsung.com
> + * Author: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> +*/
> +
> +#ifndef __DT_BINDINGS_PINCTRL_EXYNOS_H__
> +#define __DT_BINDINGS_PINCTRL_EXYNOS_H__

Minor nit:

shouldn't this be __DT_BINDINGS_PINCTRL_SAMSUNG_H__ (the header file
is named samsung.h and is going to be used also by s3c* SoCs)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics