Re: kernel/printk/printk.c: Invalid access when buffer wraps around?

From: Vincent Brillault
Date: Fri Aug 05 2016 - 13:23:14 EST


Dear Ivan, all

Sorry for the delay, I currently have limited internet access.

> Thanks for your very detailled write-up but I believe you are mistaken
> on the value of log_first_idx between these two last steps you describe.

After re-reading log_next and log_make_free_space, I believe that you
are right and that I was wrong. Your explanation is crystal-clear and I
now don't understand how I missed this (it's even explained in the
comments...). This means that we might be removing the first element in
the buffer while there was enough space to store it at the end of the
buffer, but I guess this is better than having a bug ;)

I'm sorry for the noise everyone. Thank you for your patience and great
explanation.

Sincerely yours,
Vincent Brillault

Attachment: signature.asc
Description: OpenPGP digital signature