Re: [PATCH v2] efi: capsule: allocate whole capsule into virtual memory

From: Matt Fleming
Date: Fri Aug 05 2016 - 07:47:01 EST


On Thu, 28 Jul, at 03:30:29PM, Christ, Austin wrote:
> According to UEFI 2.6 section 7.5.3, the capsule should be in contiguous
> virtual memory and firmware may consume the capsule immediately. To
> correctly implement this functionality, the kernel driver needs to vmap
> the entire capsule at the time it is made available to firmware.
>
> The virtual allocation of the capsule update has been changed from kmap,
> which was only allocating the first page of the update, to vmap, and
> allocates the entire data payload.
>
> Signed-off-by: Austin Christ <austinwc@xxxxxxxxxxxxxx>
> Reviewed-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Lee, Chun-Yi <jlee@xxxxxxxx>
> ---
> drivers/firmware/efi/capsule-loader.c | 8 +++++---
> drivers/firmware/efi/capsule.c | 6 +++---
> 2 files changed, 8 insertions(+), 6 deletions(-)

Thanks, applied.