Re: [PATCH v3 1/7] random: Simplify API for random address requests

[Yann Droneaud]

Hi,

Le mercredi 03 aoÃt 2016 Ã 23:39 +0000, Jason Cooper a ÃcritÂ:
>Â
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 0158d3bff7e5..61cb434e3bea 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1840,6 +1840,39 @@ randomize_range(unsigned long start, unsigned
> long end, unsigned long len)
> Â	return PAGE_ALIGN(get_random_int() % range + start);
> Â}
> Â
> +/**
> + * randomize_page - Generate a random, page aligned address
> + * @start:	The smallest acceptable address the caller will
> take.
> + * @range:	The size of the area, starting at @start, within
> which the
> + *		random address must fall.
> + *
> + * If @start + @range would overflow, @range is capped.
> + *
> + * NOTE: Historical use of randomize_range, which this replaces,
> presumed that
> + * @start was already page aligned.ÂÂWe now align it regardless.
> + *
> + * Return: A page aligned address within [start, start + range).ÂÂOn
> error,
> + * @start is returned.
> + */
> +unsigned long
> +randomize_page(unsigned long start, unsigned long range)
> +{

To prevent an underflow if start is not page aligned (but will one
would ever use a non aligned start address *and* range ? ...)

ÂÂÂÂÂÂÂÂif (range < PAGE_SIZE)
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn start;


> +	if (!PAGE_ALIGNED(start)) {
> +		range -= PAGE_ALIGN(start) - start;
> +		start = PAGE_ALIGN(start);
> +	}
> +
> +	if (start > ULONG_MAX - range)
> +		range = ULONG_MAX - start;
> +
> +	range >>= PAGE_SHIFT;
> +
> +	if (range == 0)
> +		return start;
> +
> +	return start + (get_random_long() % range << PAGE_SHIFT);
> +}
> +
> Â/* Interface for in-kernel drivers of true hardware RNGs.
> Â * Those devices may produce endless random bits and will be
> throttled
> Â * when our pool is full.
>Â

Regards.

--Â
Yann Droneaud
OPTEYA