Re: [git pull] drm for v4.8

From: Ville Syrjälä
Date: Tue Aug 02 2016 - 14:35:57 EST


On Tue, Aug 02, 2016 at 08:01:14PM +0200, Daniel Vetter wrote:
> On Tue, Aug 2, 2016 at 6:40 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, Aug 2, 2016 at 4:10 AM, Ville Syrjälä
> > <ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> >>
> >> So PSR seems more likely. The underruns might point at some watermark
> >> fail though :(
> >>
> >> I have a couple of pending PSR patches you may want to try as well,
> >> if i915.enable_psr=0 helps.
> >>
> >> First set is here:
> >> git://github.com/vsyrjala/linux.git psr_setup_time_2
> >> This should be perfectly safe to go in actually, as it will only result
> >> in disabling PSR with certain panels.
> >
> > This first git pull fixes it for me, as far as I can tell. I'm not
> > sure that the problem is 100% reproducible, but I booted into each
> > kernel twice, and the current git tree is broken, while with your
> > psr_setup_time_2 branch pulled it works. So it does seem to be the
> > fix.
> >
> >> The second set is here:
> >> git://github.com/vsyrjala/linux.git psr_fixes_2
> >
> > I didn't even test that one.
> >
> > Should I just pull that psr_setup_time2 branch for real? I'd like to
> > get a real pull request with explanations etc, but other than that it
> > looks good to go.
>
> Hm, I reviewed all the patches from Ville already. I gues they were
> stuck because we didn't have someone who reported that it's fixed,
> plus they lacked an ack from Dave for the 2 core patches.

+ they were part of a series that included a rotten apple responsible
for a BAT regression

> tbh I'd just
> apply them all to drm-intel-fixes and then send out a pull for that
> (there's two more bugfix patches on it which missed Dave's main pull
> by a notch). Dave/Jani?
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

--
Ville Syrjälä
Intel OTC