Re: [kernel-hardening] Re: [PATCH v2 1/7] random: Simplify API for random address requests

From: Michael Ellerman
Date: Mon Aug 01 2016 - 23:37:05 EST


Jason Cooper <jason@xxxxxxxxxxxxxx> writes:
> On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote:
>> On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper <jason@xxxxxxxxxxxxxx> wrote:
>>
>> I have no new call sites in mind, but it seems safe to add a BUG_ON to
>> verify we don't gain callers that don't follow the correct
>> expectations. (Or maybe WARN and return start.)
>
> No, I think BUG_ON is appropriate. afaict, the only time this will be
> encountered is during the development process.

Unless it's not.

Why crash someone's system when you could just page align the value
you're given?

cheers