Re: [PATCH] firmware-gsmi: Delete an unnecessary check before the function call "dma_pool_destroy"

[Mike Waychison]

On Mon, Aug 1, 2016 at 5:04 AM, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, 24 Jul, at 10:27:49AM, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Sun, 24 Jul 2016 10:16:56 +0200
> >
> > The dma_pool_destroy() function tests whether its argument is NULL
> > and then returns immediately. Thus the test around the call is not needed.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/firmware/google/gsmi.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Looks fine to me. If Mike doesn't pick this up I'll take it through
> the EFI tree.

Yes please do.