Re: Why do we need reset_control_get_optional() ?

From: Arnd Bergmann
Date: Sat Jul 30 2016 - 16:15:27 EST


On Friday, July 29, 2016 3:08:15 PM CEST Philipp Zabel wrote:
> Hi Masahiro,
>
> Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada:
> [...]
> > However, I think the following makes more sense:
> >
> >
> > menuconfig RESET_CONTROLLER
> > bool "Reset Controller Support"
> > depends on (ARCH_HAS_RESET_CONTROLLER || COMPILE_TEST)
> > default y
> > help
> > Generic Reset Controller support.
>
> That looks sensible to me. You'll only have to enable the reset
> controller framework if either some enabled architecture has a reset
> controller (in which case you want the driver for it to be activated by
> default), or if you want to compile test some of the reset drivers.

This still doesn't let a platform 'select RESET_FOO', unless they
also select RESET_CONTROLLER and ARCH_HAS_RESET_CONTROLLER.

Why do we need to guard all drivers inside of two symbols?

Arnd