Re: [PATCH v2 1/4] net: ethernet: ti: cpdma: fix lockup in cpdma_ctlr_destroy()

From: Mugunthan V N
Date: Fri Jul 29 2016 - 04:16:52 EST


On Thursday 28 July 2016 11:20 PM, Grygorii Strashko wrote:
> Fix deadlock in cpdma_ctlr_destroy() which is triggered now on
> cpsw module removal:
> cpsw_remove()
> - cpdma_ctlr_destroy()
> - spin_lock_irqsave(&ctlr->lock, flags)
> - cpdma_ctlr_stop()
> - spin_lock_irqsave(&ctlr->lock, flags);
> - cpdma_chan_destroy()
> - spin_lock_irqsave(&ctlr->lock, flags);
>
> The issue has not been observed before because CPDMA channels have
> been destroyed manually by CPSW until commit d941ebe88a41 ("net:
> ethernet: ti: cpsw: use destroy ctlr to destroy channels") was merged.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

Reviewed-by: Mugunthan V N <mugunthanvnm@xxxxxx>

Regards
Mugunthan V N