Re: [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in XSAVES compacted-format buffer

From: Ingo Molnar
Date: Wed Jul 27 2016 - 05:00:40 EST



* Sai Praneeth Prakhya <sai.praneeth.prakhya@xxxxxxxxx> wrote:

> From: Sai Praneeth <sai.praneeth.prakhya@xxxxxxxxx>
>
> Currently, XSAVES compacted-format buffer will always contain space for
> all enabled states. If XSAVES compacted-format buffer is in use and
> an xstate component (E.g: PKRU xstate) is not present in the buffer
> (i.e. xcomp_bv does not have xfeature (E.g: XFEATURE_MASK_PKRU) bit
> set), then fpu__xfeature_set_state() returns error.

Please fix the changelog to conform to the standard changelog style:

- first describe the symptoms of the bug - how does a user notice?

- then describe how the code behaves today and how that is causing the bug

- and then only describe how it's fixed.

Thanks,

Ingo