Re: [PATCH v2 00/13] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v2

From: Philipp Zabel
Date: Tue Jul 26 2016 - 06:06:39 EST


Hi Steve,

Am Dienstag, den 19.07.2016, 18:10 -0700 schrieb Steve Longerbeam:
> These updates to IPUv3 are needed for media staging drivers
> for i.MX5/6 video capture and mem2mem.
>
> Steve Longerbeam (13):
> gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset()
> gpu: ipu-cpmem: Add ipu_cpmem_get_burstsize()
> gpu: ipu-v3: Add ipu_get_num()
> gpu: ipu-v3: Add VDI input IDMAC channels
> gpu: ipu-v3: set correct full sensor frame for PAL/NTSC
> gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats
> gpu: ipu-v3: Fix IRT usage
> gpu: ipu-v3: rename CSI client device

I have applied these.

> gpu: ipu-v3: Add Video Deinterlacer unit
> gpu: ipu-v3: Add IDMA channel linking support
> gpu: ipu-v3: Add ipu_set_vdi_src_mux()
> gpu: ipu-ic: Add complete image conversion support with tiling
> gpu: ipu-ic: allow multiple handles to ic

But I have questions or comments for these.

The VDI depends on ipu_set_vdi_src_mux, which I still don't think is in
the correct place. Channel linking looks mostly ok to me, but the image
converter tiling doesn't work with fixed size tiles. See the other mails
for details.

best regards
Philipp