Re: [PATCH v2] Documentation/watchdog: check return value for magic close

From: Timur Tabi
Date: Fri Jul 22 2016 - 17:30:21 EST


Arnd Bergmann wrote:
A recent commit added a write to the watchdog test code for doing the "magic
close", but that caused a compile-time warning:

Documentation/watchdog/src/watchdog-test.c: In function âmainâ:
Documentation/watchdog/src/watchdog-test.c:94:5: warning: ignoring return value of âwriteâ, declared with attribute warn_unused_result [-Wunused-result]

This changes the code to print a runtime warning if the write fails.

Fixes: 5a2d3de19602 ("Documentation/watchdog: add support for magic close to watchdog-test")
Signed-off-by: Arnd Bergmann<arnd@xxxxxxxx>

Acked-by: Timur Tabi <timur@xxxxxxxxxxxxxx>

Thanks for this patch. I don't know why I didn't notice the warnings before.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.