Re: linux-next: build warnings after merge of the libata tree

From: Tejun Heo
Date: Thu Jul 21 2016 - 10:45:07 EST


Hello, Stephen.

On Thu, Jul 21, 2016 at 03:26:03PM +1000, Stephen Rothwell wrote:
> Hi Tejun,
>
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warning:
>
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> ^
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
> if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
> ^
>
> Introduced by commit
>
> 9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()")

Already reverted the patch. Sorry about that.

Thanks.

--
tejun