Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting

[Jonathan Cameron]

On 19/07/16 08:13, Wolfram Sang wrote:
> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote:
>> On 18/07/16 09:50, Laxman Dewangan wrote:
>>>
>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote:
>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting
>>>> auto-detection.  IIO drivers don't typically use .class.
>>>> Remove it.
>>>>
>>>> Signed-off-by: Alison Schofield <amsfield22@xxxxxxxxx>
>>>> Cc: Daniel Baluta <daniel.baluta@xxxxxxxxx>
>>>>
>>>
>>> Agree.
>>> Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
>> Any resulting ABI change from dropping it?
> 
> What do you mean with ABI? This is only relevant for "automatic"
> instantiation.
Cool, I was just being paranoid and didn't have time to check!

Thanks,

Jonathan
> From me:
> 
> Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx>
>