Re: [PATCH 02/14] resource limits: aggregate task highwater marks to cgroup level

From: Tejun Heo
Date: Tue Jul 19 2016 - 14:18:29 EST


Hello, Topi.

On Tue, Jul 19, 2016 at 04:57:10PM +0000, Topi Miettinen wrote:
> Then there would need to be new limit checks at cgroup level. Would you
> see problems with that approach?

I'm worried that you're rushing this feature without thinking through
it. You were mixing up completely orthogonal planes of accounting and
control without too much thought and are now suggesting something
which is also strange. What do you mean by "new limit checks at
cgroup level"? How would this be different from the resource
accounting and control implemented in the existing controllers?

Please take a step back and think through the overall design before
proposing changes to userland visible interface.

Thanks.

--
tejun