[PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM

From: Paolo Bonzini
Date: Tue Jul 19 2016 - 06:50:29 EST


People complain about the driver saying there's no valid RAPL domains
in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO
if running on a hypervisor, since it is basically stating the obvious.

Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
---
First sent out about a year ago. :)

drivers/powercap/intel_rapl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index b2766b867b0e..0a0b09910116 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
}
rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX);
if (!rp->nr_domains) {
- pr_err("no valid rapl domains found in package %d\n", rp->id);
+ printk("%sNo valid RAPL domains found in package %d\n",
+ boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR,
+ rp->id);
ret = -ENODEV;
goto done;
}
--
2.7.4