[PATCH] checkpatch: Yet another commit id improvement

From: Joe Perches
Date: Mon Jul 18 2016 - 15:27:54 EST


Using \b isn't good enough to isolate what appears to be a
commit id in a commit message.

Make sure there is a space or a quote like character after
a continuous run of hexadecimal characters that could be
a commit id.

Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
cc: "Zhuo, Qiuxu" <qiuxu.zhuo@xxxxxxxxx>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index a0e5112..8209ae5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2460,9 +2460,9 @@ sub process {

# Check for git id commit length and improperly formed commit descriptions
if ($in_commit_log && !$commit_log_possible_stack_dump &&
- $line !~ /^\s*(?:Link|Patchwork|http|BugLink):/i &&
+ $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
- ($line =~ /\b[0-9a-f]{12,40}\b/i &&
+ ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
$line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
$line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
my $init_char = "c";
--
2.8.0.rc4.16.g56331f8