Re: [patch V2 23/67] bus/arm-ccn: Convert to hotplug statemachine

From: Pawel Moll
Date: Mon Jul 18 2016 - 14:37:42 EST


Dnia 2016-07-13, Wed o godzinie 17:16 +0000, Anna-Maria Gleixner pisze:
> From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>
> Install the callbacks via the state machine and let the core invoke
> the callbacks on the already online CPUs.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Pawel Moll <pawel.moll@xxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>

> @@ -1316,7 +1309,6 @@ static void arm_ccn_pmu_cleanup(struct a
> ida_simple_remove(&arm_ccn_pmu_ida, ccn->dt.id);
> }
>
> -
> static int arm_ccn_for_each_valid_region(struct arm_ccn *ccn,
> int (*callback)(struct arm_ccn *ccn, int region,
> void __iomem *base, u32 type, u32 id))

This empty line doesn't impact hotplug, does it? ;-)

With this chunk dropped

Acked-by: Pawel Moll <pawel.moll@xxxxxxx>

Cheers!

Pawel