Re: [patch] video: fbdev: pxafb: potential NULL dereference on error

From: Robert Jarzmik
Date: Sun Jul 17 2016 - 11:20:35 EST


Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:

> If we "goto out;" then it calls display_timings_release(timings);
> Since "timings" is NULL, that's going to oops. Just return directly.
>
> Fixes: 420a488278e8 ('video: fbdev: pxafb: initial devicetree conversion')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Cheers.

--
Robert