Re: [PATCH 5/5] mm, vmscan: Update all zone LRU sizes before updating memcg

From: Mel Gorman
Date: Fri Jul 15 2016 - 11:01:49 EST


On Fri, Jul 15, 2016 at 11:45:34PM +0900, Minchan Kim wrote:
> > +static __always_inline void update_lru_sizes(struct lruvec *lruvec,
> > + enum lru_list lru, unsigned long *nr_zone_taken,
> > + unsigned long nr_taken)
> > +{
> > +#ifdef CONFIG_HIGHMEM
>
> If you think it's really worth to optimize it for non-highmem system,
> we don't need to account nr_zone_taken in *isolate_lru_pages*
> from the beginning for non-highmem system, either.
>

It becomes a mess of ifdefs and given the marginal overhead, I left it
for now.

--
Mel Gorman
SUSE Labs