Re: [PATCH 18/36] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments

From: Johan Hovold
Date: Fri Jul 15 2016 - 07:36:34 EST


On Thu, May 12, 2016 at 10:48:50AM +0200, Mathieu OTHACEHE wrote:
> Remove useless ti_device pointer, and change addr to u32.
> Move function upper to avoid function prototyping.

That's just noise. Having an occasional prototype is just fine. You may
want to consider reordering functions for the first submission, but no
need to move things around after that.

> Also change size variable in function from int to size_t.

Combining changes with moving code, makes it harder to review for no
good reason.

Thanks,
Johan