Re: [PATCH 0/8] x86: audit and remove needless module.h includes

From: Ingo Molnar
Date: Thu Jul 14 2016 - 14:56:32 EST



* Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote:

> [Re: [PATCH 0/8] x86: audit and remove needless module.h includes] On 14/07/2016 (Thu 20:39) Ingo Molnar wrote:
>
> >
> > * Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote:
> >
> > > > I'll continue testing with the setup_percpu.c change left out.
> > >
> > > Let me know if you want a resend or if you want to just add the
> > > asm/desc.h locally or ...
> >
> > So I tried the asm/desc.h but saw other build failures - for now gave up.
> > Can we do this in a separate patch?
>
> Yes of course. In the meantime I'll investigate further and add more
> configs to my testing. Is there a list of the configs used for sanity
> testing tip somewhere?

No need for you to complicate your testing (unless you have enough hardware
resources for that) - I can deal with the occasional build failure. Since I
eventually create and boot randconfigs there's no fixed set of configs. :-/

That I enabled SMP on the "allnoconfig" (and forgot about it!) has to do with the
fact that even my allnoconfigs are typically bootable (on one of my test systems)
so there's a handful of pre-baked configs that always get enabled.

But other than those small perturbations I do similar testing to what you did:
all{no|def|mod|yes}config on x86-{32|64}, plus randconfigs.

Thanks,

Ingo