[PATCH net-next] rxrpc: checking for IS_ERR() instead of NULL

From: David Howells
Date: Thu Jul 14 2016 - 11:23:57 EST


From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

The rxrpc_lookup_peer() function returns NULL on error, it never returns
error pointers.

Fixes: 8496af50eb38 ('rxrpc: Use RCU to access a peer's service connection tree')
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
---

net/rxrpc/conn_service.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rxrpc/conn_service.c b/net/rxrpc/conn_service.c
index 7cbd612be0d7..fd9027ccba8f 100644
--- a/net/rxrpc/conn_service.c
+++ b/net/rxrpc/conn_service.c
@@ -163,7 +163,7 @@ struct rxrpc_connection *rxrpc_incoming_connection(struct rxrpc_local *local,

if (!peer) {
peer = rxrpc_lookup_peer(local, srx, GFP_NOIO);
- if (IS_ERR(peer))
+ if (!peer)
goto enomem;
}