Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine

From: Peter Zijlstra
Date: Thu Jul 14 2016 - 05:42:18 EST


On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote:
> On 07/14/2016 09:47 AM, Ingo Molnar wrote:
> >
> >* Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> wrote:
> >
> >>>@@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void)
> >>> }
> >>>
> >>> register_syscore_ops(&ledtrig_cpu_syscore_ops);
> >>>- register_cpu_notifier(&ledtrig_cpu_nb);
> >>>+
> >>>+ /*
> >>>+ * FIXME: Why needs this to happen in the interrupt disabled
> >>>+ * low level bringup phase of a cpu?
> >>>+ */

> Thanks for the explanation. I'm OK with that approach.

Since we have your attention, could you perhaps attempt to answer the
question so we can fix the fixme?