Re: [PATCH] kprobes: include <asm/sections.h> instead of <asm-generic/sections.h>

From: Masami Hiramatsu
Date: Wed Jul 13 2016 - 11:13:54 EST


On Tue, 12 Jul 2016 09:57:36 +0900
Christoph Hellwig <hch@xxxxxx> wrote:

> asm-generic headers are generic implementations for architecture specific
> code and should not be included by common code. Thus use the asm/ version
> of sections.h to get at the linker sections.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good to me. Thanks Christoph!

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

> ---
> kernel/kprobes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index d10ab6b..d630954 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -49,7 +49,7 @@
> #include <linux/cpu.h>
> #include <linux/jump_label.h>
>
> -#include <asm-generic/sections.h>
> +#include <asm/sections.h>
> #include <asm/cacheflush.h>
> #include <asm/errno.h>
> #include <asm/uaccess.h>
> --
> 2.1.4
>


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>