Re: [PATCH] device-tree: nexus7: Set phy mode to otg instead of host

From: Bjorn Andersson
Date: Tue Jul 12 2016 - 14:36:41 EST


On Fri 01 Jul 22:33 PDT 2016, John Stultz wrote:

> In order to have the usb phy work in gadget mode, override
> the default host mode with otg mode.
>
> This allows gadget mode to work w/o any hacks to the dtsi file.
>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Andy Gross <agross@xxxxxxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: Stephen Boyd <stephen.boyd@xxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: John Stultz <john.stultz@xxxxxxxxxx>
> ---
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> index 7b05f07..94e9cbb 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -253,6 +253,7 @@
> vddcx-supply = <&pm8921_s3>;
> v3p3-supply = <&pm8921_l3>;
> v1p8-supply = <&pm8921_l4>;
> + dr_mode = "otg";

Wouldn't this be the standard case for the first/primary USB on most
8064s? Looks like both the ifc6410 and sd600eval has OTG support on the
micro-usb.

Andy, how about we just change the dtsi instead?

Regards,
Bjorn