Re: [PATCH] Input: /input/mouse/elan_i2c_core.c Fix some Asus touchapod which casue TP no funciton sometimes, the patch detect some specific touchpad and run a special initialize

From: 'Dmitry Torokhov'
Date: Mon Jul 11 2016 - 13:03:30 EST


On Mon, Jul 11, 2016 at 08:40:58PM +0800, ååæ wrote:
> > +
> > + error = data->ops->get_sm_version(client, &data->ic_type,
> > + &data->sm_version);
> > + if (error)
> > + return false;
>
> That means we'd be fetching product ID and IC type twice when initializing the device. Can we come with a way to do it once?
> [KT]:Because the elan_query_device_info() is behind the elan_initialize(). That's why I fetching product ID and IC type in the elan_initialize()
> I will discuss with FW team and then execute elan_query_device_info() first to get product_id and ic_type.

We might need to split fetching product ID and IC type form the rest of
the device info.

Thanks.

--
Dmitry