Re: [patch 02/66] irqchip/gic: Convert to hotplug state machine

[Ingo Molnar]

* Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx> wrote:

> More or less straightforward, although this driver sports some very
> interesting SMP setup code. Regarding the callback ordering, this
> deleted comment is interesting:
> 
>    ... the GIC needs to be up before the ARM generic timers.
> 
> That comment is half baken as the same requirement is true for perf.
> 
> Signed-off-by: Richard Cochran <rcochran@xxxxxxxxxxxxx>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>

The SOB sequence is unusal. Is this patch missing this line:

  From: Richard Cochran <rcochran@xxxxxxxxxxxxx>

... or should the SOB be:

  Acked-by: Richard Cochran <rcochran@xxxxxxxxxxxxx>

?

Thanks,

	Ingo