Re: cxl: make base more explicitly non-modular

From: Michael Ellerman
Date: Mon Jul 11 2016 - 06:19:35 EST


On Sun, 2016-03-07 at 20:31:53 UTC, Paul Gortmaker wrote:
> The Kconfig/Makefile currently controlling compilation of this code is:
>
> drivers/misc/cxl/Kconfig:config CXL_BASE
> drivers/misc/cxl/Kconfig: bool
>
> drivers/misc/cxl/Makefile:obj-$(CONFIG_CXL_BASE) += base.o
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets convert the one module_init into device_initcall so that
> when reading the driver it more clear that it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We don't replace module.h with init.h since the file is doing
> other modular stuff (module_get/put) even though it is built-in.
>
> Cc: Ian Munsie <imunsie@xxxxxxxxxxx>
> Cc: Michael Neuling <mikey@xxxxxxxxxxx>
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Acked-by: Ian Munsie <imunsie@xxxxxxxxxxx>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/e00878be3f414a99234b3c9613

cheers