Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist

[Wangnan (F)]

On 2016/7/8 22:48, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote:
>
> SNIP
>
> >   	ret = TEST_FAIL;
> > -	err = do_test(evlist, opts.mmap_pages, &sample_count,
> > +	err = do_test(evlist, aux_evlist, opts.mmap_pages,
> > +		      &enter_sample_count, &exit_sample_count,
> >   		      &comm_count);
> >   	if (err != TEST_OK)
> >   		goto out_delete_evlist;
> >   
> > -	if ((sample_count != NR_ITERS) || (comm_count != NR_ITERS)) {
> > -		pr_err("Unexpected counter: sample_count=%d, comm_count=%d\n",
> > -		       sample_count, comm_count);
> > +	if (enter_sample_count != exit_sample_count) {
> > +		pr_err("Unexpected counter: enter_sample_count=%d, exit_sample_count=%d\n",
> > +		       enter_sample_count, exit_sample_count);
> > +		goto out_delete_evlist;
> > +	}
> > +
> > +	if ((exit_sample_count != NR_ITERS) || (comm_count != NR_ITERS)) {
> > +		pr_err("Unexpected counter: exit_sample_count=%d, comm_count=%d\n",
> > +		       exit_sample_count, comm_count);
> >   		goto out_delete_evlist;
> >   	}
> >   
> > -	err = do_test(evlist, 1, &sample_count, &comm_count);
> > +	err = do_test(evlist, aux_evlist, 1, &dummy, &dummy, &dummy);
> why dont you test numbers for 1 page mmap?  seems like the data would fit..
> is the purpose just to check if we can map just 1 page?

Data won't fit. 1 page map make sure the buffer is overwritten.

Thank you.

> thanks,
> jirka