Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes

From: Dmitry Torokhov
Date: Fri Jul 08 2016 - 17:08:41 EST


On Tue, Jun 28, 2016 at 06:17:13PM +0200, Martin Kepplinger wrote:
> Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov:
> > Hi Martin,
> >
> > On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote:
> >> static int pegasus_reset_resume(struct usb_interface *intf)
> >> {
> >> + struct pegasus *pegasus = usb_get_intfdata(intf);
> >> +
> >> + if (pegasus->dev->users)
> >> + pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE);
> >> +
> >> return pegasus_resume(intf);
> >
> > Hmm, we need to take input mutex when using pegasus->dev->users, how
> > about the version below instead?
> >
> > Thanks.
> >
>
> Sorry for the delay, give me a few more days to test and confirm this or
> come up with a final patch.

Martin, did you have time to try out this version of the patch?

Thanks!

--
Dmitry