Re: [PATCH v14 3/8] perf tests: Add testcase for auxiliary evlist

From: Jiri Olsa
Date: Fri Jul 08 2016 - 10:48:53 EST


On Thu, Jul 07, 2016 at 05:34:44AM +0000, Wang Nan wrote:

SNIP

> }
> diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
> index 99bcc02..d736cd3 100644
> --- a/tools/perf/util/evlist.h
> +++ b/tools/perf/util/evlist.h
> @@ -149,6 +149,14 @@ union perf_event *perf_evlist__mmap_read_backward(struct perf_evlist *evlist,
> int idx);
> void perf_evlist__mmap_read_catchup(struct perf_evlist *evlist, int idx);
>
> +static inline void perf_evlist__mmap_read_catchup_all(struct perf_evlist *evlist)
> +{
> + int i;
> +
> + for (i = 0; i < evlist->nr_mmaps; i++)
> + perf_evlist__mmap_read_catchup(evlist, i);
> +}

any reason for this to be inline and not
static within tests/backward-ring-buffer.c?

thanks,
jirka