Re: [PATCH] x86/asm/entry: Make thunk's restore a local label

From: Ingo Molnar
Date: Fri Jul 08 2016 - 09:39:23 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> From: Borislav Petkov <bp@xxxxxxx>
>
> No need to have it appear in objdump output.
>
> No functionality change.
>
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> ---
> arch/x86/entry/thunk_64.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S
> index 027aec4a74df..7b506f52a92c 100644
> --- a/arch/x86/entry/thunk_64.S
> +++ b/arch/x86/entry/thunk_64.S
> @@ -33,7 +33,7 @@
> .endif
>
> call \func
> - jmp restore
> + jmp .Lrestore

Btw., could we make it .L_restore to make it more readable - or does the
underscore confuse tooling?

Thanks,

Ingo