Re: [RFC] [PATCH v2 1/3] scatterlist: Add support to clone scatterlist

From: Mark Brown
Date: Fri Jul 08 2016 - 04:19:33 EST


On Thu, Jul 07, 2016 at 07:43:25PM +0200, Robert Jarzmik wrote:

> I'll try, but I don't trust much my chances of success, given that this tester :
> - should compile and link in $(TOP)/lib/scatterlist.c, as this is where
> sg_split() is defined
> - this implies all its includes
> - this implies at least these ones :
> bug.h
> mm.h
> scatterlist.h
> string.h
> types.h
> - this implies having page_to_phys and co. defined somewhere without
> draining the whole include/linux and include/asm* trees

> For the tester, I had created an apart include/linux tree where all the includes
> were _manually_ filled in with minimal content.

> I don't know if an existing selftest had already this kind of problem,
> ie. having to compile and link a kernel .c file, and that makes me feel this
> might be difficult to keep a nice standalone tester.

Right, that's messy :( Could it be refactored as a boot/module load
time test so it could be built in the kernel environment? Less
convenient to use (though KVM/UML help) but easier to build.

Attachment: signature.asc
Description: PGP signature